solo-io / gloo

The Feature-rich, Kubernetes-native, Next-Generation API Gateway Built on Envoy
https://docs.solo.io/
Apache License 2.0
4.07k stars 437 forks source link

glooctl checking virtual services depends on checking upstreams #7584

Open nfuden opened 1 year ago

nfuden commented 1 year ago

Gloo Edge Version

1.14.x (beta)

Kubernetes Version

None

Describe the bug

When glooctl is run with the exclude upstreams flag it will error on virutal services that refer to any upstreams.

User will see something like: `Error: 2 errors occurred:

Steps to reproduce the bug

  1. Setup a valid vs that points to a valid us (follow any example)
  2. glooctl check | grep error should find nothing
  3. gloocl check --exclude deployments,upstreams,rate-limit-configs,secrets,auth-configs | grep error finds error...

Expected Behavior

glooctl at worst warns on vs if skipping upstream checks or warns that the check could be incomplete but should not throw an error.

Additional Context

When debugging in a simple environment glooctl check is decently slower than glooctl check --exclude deployments,upstreams,rate-limit-configs,secrets,auth-configs So it would be nice if it worked.

github-actions[bot] commented 3 months ago

This issue has been marked as stale because of no activity in the last 180 days. It will be closed in the next 180 days unless it is tagged "no stalebot" or other activity occurs.