solo-io / gloo

The Feature-rich, Kubernetes-native, Next-Generation API Gateway Built on Envoy
https://docs.solo.io/
Apache License 2.0
4.09k stars 438 forks source link

Makefile variable checks #7822

Open nfuden opened 1 year ago

nfuden commented 1 year ago

Version

None

Is your feature request related to a problem? Please describe.

Today we have comments in the makefile that have the form this variable must be in state x that relates to thing y

This is a fragile linkage and requires members to update when they can. We should find ways to programmatically determine if we are / are not in sync and or programmatically update the dependencies.

Describe the solution you'd like

A specific generation command that will be added to the generate-all command that will take care of all things that need to be in lockstep across the makefile and potentially ci steps.

Describe alternatives you've considered

Adding large commands for every make variable such as go list -m all | grep github.com/onsi/ginkgo/v2 | awk '{print $2} (https://github.com/solo-io/solo-kit/pull/537#discussion_r1101574244)

Additional Context

No response

nfuden commented 1 year ago

@sam-heilbron follow up to pr discussion around approaches to keep makefile in lockstep

github-actions[bot] commented 4 months ago

This issue has been marked as stale because of no activity in the last 180 days. It will be closed in the next 180 days unless it is tagged "no stalebot" or other activity occurs.