search

solo-io / gloo

The Feature-rich, Kubernetes-native, Next-Generation API Gateway Built on Envoy
https://docs.solo.io/
Apache License 2.0
4.08k stars 437 forks source link

Enable Spell Check in CI #7923

Open sam-heilbron opened 1 year ago

sam-heilbron commented 1 year ago

Version

None

Is your feature request related to a problem? Please describe.

It's easy to misspell words and we should have automation to protect against this.

Describe the solution you'd like

We have an existing script: https://github.com/solo-io/gloo/blob/master/ci/spell.sh

As part of: https://github.com/solo-io/gloo/pull/7910, we identified that this script was doing nothing so it was removed from being executed in our CI pipeline.

We should have a spellcheck script running in CI. Ideally as part of a static analysis action that runs our codegen and spellcheck, though open to other locations as long as it prevents merges from misspellings.

Describe alternatives you've considered

No response

Additional Context

Github conversation: https://github.com/solo-io/gloo/pull/7910#discussion_r1124577128

nfuden commented 1 year ago

We might actually want to turn on golang-ci instead and start with its mispell linter.

github-actions[bot] commented 2 months ago

This issue has been marked as stale because of no activity in the last 180 days. It will be closed in the next 180 days unless it is tagged "no stalebot" or other activity occurs.