search

solo-io / gloo

The Feature-rich, Kubernetes-native, Next-Generation API Gateway Built on Envoy
https://docs.solo.io/
Apache License 2.0
4.06k stars 433 forks source link

Fed canary upgrades: object has been modified errors #7984

Open jenshu opened 1 year ago

jenshu commented 1 year ago

Gloo Edge Version

1.14.x (beta)

Kubernetes Version

None

Describe the bug

When two Gloo Fed controllers running on the same management cluster try to update the status for the same federated resource at the same time, one controller's status update will initially fail with object has been modified errors. This is typically resolved after auto-retrying, but it adds unnecessary noise to the logs.

Steps to reproduce the bug

Follow steps outlined in #7529

When an update is made to the FederatedUpstream, check the logs for both gloo-fed pods and see the errors.

Expected Behavior

Ideally there would be no errors when the fed controllers update the statuses.

We can try to use Patch instead of Update for status updates, which should help

Additional Context

No response

github-actions[bot] commented 2 months ago

This issue has been marked as stale because of no activity in the last 180 days. It will be closed in the next 180 days unless it is tagged "no stalebot" or other activity occurs.