search

solo-io / gloo

The Feature-rich, Kubernetes-native, Next-Generation API Gateway Built on Envoy
https://docs.solo.io/
Apache License 2.0
4.04k stars 431 forks source link

Fed canary upgrades: GlooInstance disappears when 2nd cluster is registered under same name #7987

Open jenshu opened 1 year ago

jenshu commented 1 year ago

Gloo Edge Version

1.14.x (beta)

Kubernetes Version

None

Describe the bug

When you have 2 Gloo Fed instances installed on the same cluster (running in different namespaces), and register a cluster for each of them using the same cluster name, only one GlooInstance is created.

Steps to reproduce the bug

Not sure if this is a regression. Follow the steps outlined in https://github.com/solo-io/gloo/issues/7529. After glooctl cluster register --federation-namespace gloo-system-old ... is called, a GlooInstance gets created in the gloo-system-old namespace. After glooctl cluster register --federation-namespace gloo-system-new... gets called, a new GlooInstance in gloo-system-new gets created, but the first GlooInstance disappears. Strangely, federation still seems to work as expected. Note this bug only occurs if both clusters were registered with the same name.

Expected Behavior

After running both cluster registration commands, there should be 2 GlooInstances (one in gloo-system-old and one in gloo-system-new)

Additional Context

Could be a problem in cluster registration or Gloo Fed discovery.

github-actions[bot] commented 1 month ago

This issue has been marked as stale because of no activity in the last 180 days. It will be closed in the next 180 days unless it is tagged "no stalebot" or other activity occurs.