search

solo-io / gloo

The Feature-rich, Kubernetes-native, Next-Generation API Gateway Built on Envoy
https://docs.solo.io/
Apache License 2.0
4.08k stars 438 forks source link

Add metric or label to count cached requests on upstreams #8413

Open jameshbarton opened 1 year ago

jameshbarton commented 1 year ago

Version

1.14.x (latest stable)

Is your feature request related to a problem? Please describe.

An Enterprise customer wants to measure the impact of caching on their overall performance. The only way to get at that information today is by scraping it from logs. They would prefer a proper metric or metric label.

Describe the solution you'd like

Either add a dedicated metric to count cached requests on upstreams, or add a label to the existing upstream_rq_total metric.

Describe alternatives you've considered

Log scraping

Additional Context

Internal Slack reference

See also this discussion.

github-actions[bot] commented 3 months ago

This issue has been marked as stale because of no activity in the last 180 days. It will be closed in the next 180 days unless it is tagged "no stalebot" or other activity occurs.