search

solo-io / gloo

The Feature-rich, Kubernetes-native, Next-Generation API Gateway Built on Envoy
https://docs.solo.io/
Apache License 2.0
4.08k stars 438 forks source link

ratelimit upstream is not deleted after disabling ratelimit #8675

Open huzlak opened 1 year ago

huzlak commented 1 year ago

Gloo Edge Product

Enterprise

Gloo Edge Version

v1.14.7

Kubernetes Version

v1.24.0

Describe the bug

After disabling ratelimit on existing installation, ratelimit upstream is not deleted so gloo keeps complaining about non existing service:

{"level":"warn","ts":"2023-09-11T23:48:07.249Z","logger":"gloo-ee.v1.event_loop.setup.gloosnapshot.event_loop.envoyTranslatorSyncer","caller":"syncer/envoy_translator_syncer.go:150","msg":"Proxy had invalid config after xds sanitization","version":"1.14.8","proxy":"name:\"gateway-proxy\"  namespace:\"kube-gloo-system\"","error":"2 errors occurred:\n\t* invalid resource kube-gloo-system.rate-limit\n\t* WARN: \n  [1 error occurred:\n\t* Upstream name:\"rate-limit\"  namespace:\"kube-gloo-system\" references the service \"rate-limit\" which does not exist in namespace \"kube-gloo-system\"\n\n]\n\n"}

If initial installation is done with ratelimit disabled, the upstream is not created and all is good.

Expected Behavior

upstream should be deleted automaticlaly when ratelimit gets disabled

Steps to reproduce the bug

  1. Install glooe with default values
  2. helm upgrade with: 
    global:
extensions:
rateLimit:
  enabled: false

Additional Environment Detail

No response

Additional Context

No response

github-actions[bot] commented 3 months ago

This issue has been marked as stale because of no activity in the last 180 days. It will be closed in the next 180 days unless it is tagged "no stalebot" or other activity occurs.