search

solo-io / gloo

The Feature-rich, Kubernetes-native, Next-Generation API Gateway Built on Envoy
https://docs.solo.io/
Apache License 2.0
4.09k stars 441 forks source link

Add condition to allow a wait for proxy deployment application when using TargetGroupBinding #8759

Open jaymiracola opened 1 year ago

jaymiracola commented 1 year ago

Gloo Edge Product

Enterprise

Gloo Edge Version

1.14.9

Is your feature request related to a problem? Please describe.

Add a wait condition for a service/ target group binding to be created before the deployment is applied for the gateway proxy. There is a race condition where in order for the proxy deployment to receive the injected readiness probes from the LBC mutating webhook, the service and target group binding need to be in place first. Otherwise, we need to rollout restart the proxy deployment for the probes to be injected in the pod spec.

Describe the solution you'd like

A helm value that sets up a wait for the proxy deployment until after the TargetGroupBinding CR is created by the AWS LBC

Describe alternatives you've considered

When using Argo, applying a sync wave to rollout restart post-sync of the proxy deployment.

Additional Context

No response

github-actions[bot] commented 4 months ago

This issue has been marked as stale because of no activity in the last 180 days. It will be closed in the next 180 days unless it is tagged "no stalebot" or other activity occurs.