search

solo-io / gloo

The Feature-rich, Kubernetes-native, Next-Generation API Gateway Built on Envoy
https://docs.solo.io/
Apache License 2.0
4.09k stars 442 forks source link

Virtual Service Selectors + Expressions silently drop configuration #8832

Open nfuden opened 1 year ago

nfuden commented 1 year ago

Gloo Edge Product

Open Source

Gloo Edge Version

1.15.x

Kubernetes Version

1.26

Describe the bug

Gateways can denote which virtual services they claim they respect. They can do this in one of three ways each which are mutually exclusive and increasingly powerful https://github.com/solo-io/gloo/blob/v1.15.0/projects/gateway/pkg/api/v1/http_gateway.pb.go#L115-L125

While our documentation says that they are mutually exclusive it does not provide any feedback to a user when they specify multiple which can lead to unexpected behavior.

Expected Behavior

When a user denotes more than one of the three options the gateway should have a warning pushing the user to use the more powerful option that they have chosen. For example if using both selectors and expressions the warning should push the user to use expressions.

Steps to reproduce the bug

Create an http gateway with both and expression and a selector, see that the selector is not respected

Additional Environment Detail

No response

Additional Context

No response

soloio-bot commented 1 year ago

Zendesk ticket #2884 has been linked to this issue.

github-actions[bot] commented 4 months ago

This issue has been marked as stale because of no activity in the last 180 days. It will be closed in the next 180 days unless it is tagged "no stalebot" or other activity occurs.