solo-io / gloo

The Feature-rich, Kubernetes-native, Next-Generation API Gateway Built on Envoy
https://docs.solo.io/
Apache License 2.0
4.04k stars 432 forks source link

Change default repository from Quay to gcr #8906

Open nfuden opened 8 months ago

nfuden commented 8 months ago

Gloo Edge Product

Open Source

Gloo Edge Version

1.16.0-beta

Is your feature request related to a problem? Please describe.

Today we push to both quay and gcr on publish of an image. Our default in our helm charts is quay Quay keeps having issues meaning anyone who has not put a private registery in place has issues pulling issues Quay keeps having problems so our ci can have issues for its upgrade tests

Describe the solution you'd like

Change the default from quay to gcr Emphasize in our production hardening guidelines that users should have a private artifact repo that they pull the images to.

Describe alternatives you've considered

n/a

Additional Context

No response

sam-heilbron commented 8 months ago

If we do this, we should update our internal tests to rely on this as well. I had tried this on a Portal PR recently and some images seemed to work and others didn't, and this varied across versions of Edge that were installed GHA logs:

+ kubectl --context kind-gloo-portal get pod -A
NAMESPACE            NAME                                                READY   STATUS             RESTARTS   AGE
gloo-portal          discovery-845666b564-sk52k                          1/1     Running            0          5m1s
gloo-portal          extauth-6679f9b5ff-hmhrv                            0/1     Running            0          5m2s
gloo-portal          gateway-proxy-78ff9754fb-gl82w                      0/1     ImagePullBackOff   0          5m1s
gloo-portal          gloo-6c74f9c56-m5spw                                0/1     ImagePullBackOff   0          5m1s
gloo-portal          gloo-ee-resource-rollout-c7pc4                      1/1     Running            0          5m
gloo-portal          rate-limit-77c96965c-sxhqb                          0/1     Running            0          5m1s
gloo-portal          redis-5bf4b88f9f-txztc                              1/1     Running            0          5m1s
kube-system          coredns-787d4945fb-g2bm7                            1/1     Running            0          6m24s
kube-system          coredns-787d4945fb-r47hb                            1/1     Running            0          6m24s
kube-system          etcd-gloo-portal-control-plane                      1/1     Running            0          6m39s
kube-system          kindnet-65gmm                                       1/1     Running            0          6m25s
kube-system          kube-apiserver-gloo-portal-control-plane            1/1     Running            0          6m39s
kube-system          kube-controller-manager-gloo-portal-control-plane   1/1     Running            0          6m39s
kube-system          kube-proxy-zsht8                                    1/1     Running            0          6m25s
kube-system          kube-scheduler-gloo-portal-control-plane            1/1     Running            0          6m39s
local-path-storage   local-path-provisioner-75f5b54ffd-6bmb2             1/1     Running            0          6m24s
github-actions[bot] commented 3 weeks ago

This issue has been marked as stale because of no activity in the last 180 days. It will be closed in the next 180 days unless it is tagged "no stalebot" or other activity occurs.