search

solo-io / gloo

The Feature-rich, Kubernetes-native, Next-Generation API Gateway Built on Envoy
https://docs.solo.io/
Apache License 2.0
4.07k stars 434 forks source link

Add custom label to all objects in kubernetes chart #9035

Open TheCubicleJockey opened 8 months ago

TheCubicleJockey commented 8 months ago

Do you have a suggestion for code improvement or tracking existing technical debt? Please describe.

This chart improvement would allow the user to include a defined label in the value.yaml, and that label would be included in the kubernetes objects in metadata.label where allowed by kubernetes. I can write the PR and it would be a short PR and clear PR.

Describe the solution you'd like

Using something like commonLabels at the top level of the values file, that can be optionally included with all the kubernetes object that allow for labeling.

Additional Context

Labels are good in kubernetes for organization and for some custom tools that read labels as a part of rule sets.

TheCubicleJockey commented 7 months ago

Am I good to make the PR?

TheCubicleJockey commented 7 months ago

My use case is for the clusterrole to have a label. So, I could make one specifically for the clusterrole, but I figured most charts have a values.commonLabels or a values.additionalLabels as a more generally acceptable version that would fit most need and my needs.

If i am doing the work, I would like to help improve the chart in a way that you or your team might like it improved.

TheCubicleJockey commented 6 months ago

PR for this work https://github.com/solo-io/gloo/pull/9195

github-actions[bot] commented 1 week ago

This issue has been marked as stale because of no activity in the last 180 days. It will be closed in the next 180 days unless it is tagged "no stalebot" or other activity occurs.