search

solo-io / gloo

The Feature-rich, Kubernetes-native, Next-Generation API Gateway Built on Envoy
https://docs.solo.io/
Apache License 2.0
4.09k stars 441 forks source link

[Helm] Gateway CRs not removed when disabling proxy in Helm values file. #9369

Open DuncanDoyle opened 6 months ago

DuncanDoyle commented 6 months ago

Gloo Edge Product

Enterprise

Gloo Edge Version

1.16.6

Kubernetes Version

1.27.8

Describe the bug

When you have deployed a Gateway using Helm, and you later disable that Gateway in the Helm values file by setting:

gatewayProxies:
  myCustomGateway:
    disabled: true

the gateway deployment, service, replicaset, etc. are correctly removed from the namespace. However, the Gloo Proxy CRs for that specific Gateway, both the standard and ssl one, are not removed.

Expected Behavior

All resources of my disabled GW are properly cleaned up.

Steps to reproduce the bug

  1. Deploy a GE Gateway with Helm.
  2. Disable the gateway by setting its disabled: true flag in your Helm values file.
  3. Run a helm upgrade
  4. Observe that the Gateway CRs are not properly cleaned up.

Additional Environment Detail

No response

Additional Context

No response

github-actions[bot] commented 1 week ago

This issue has been marked as stale because of no activity in the last 180 days. It will be closed in the next 180 days unless it is tagged "no stalebot" or other activity occurs.