solo-io / gloo

The Feature-rich, Kubernetes-native, Next-Generation API Gateway Built on Envoy
https://docs.solo.io/
Apache License 2.0
4.02k stars 433 forks source link

Expose max_buffered_{rx/tx}_bytes in the Tap filter #9656

Open sadieleob opened 1 week ago

sadieleob commented 1 week ago

Gloo Edge Product

Enterprise

Gloo Edge Version

1.17

Is your feature request related to a problem? Please describe.

This is not related to an issue.

Describe the solution you'd like

The customer is asking to expose:

The customer stated that without the maxbuffered<rx/tx>_bytes fields set, the maximum body size is 1KiB that can be sent to the tap filter. Unfortunately, this max body size blocks our integration of the tap filter with their "in-house monetization" project since it requires payloads up to 4KB.

For the streaming field, this is not as important, but they would like to have this available in case buffering causes Envoy performance issues.

https://www.envoyproxy.io/docs/envoy/latest/api-v3/config/tap/v3/common.proto#config-tap-v3-outputconfig https://www.envoyproxy.io/docs/envoy/latest/api-v3/extensions/filters/http/tap/v3/tap.proto#extensions-filters-http-tap-v3-tap

Describe alternatives you've considered

There are no alternatives

Additional Context

No response

soloio-bot commented 1 week ago

Zendesk ticket #3974 has been linked to this issue.

nfuden commented 1 week ago

https://github.com/solo-io/solo-projects/issues/5455 encompasses this as well. @DuncanDoyle