search

solo-io / gloo

The Feature-rich, Kubernetes-native, Next-Generation API Gateway Built on Envoy
https://docs.solo.io/
Apache License 2.0
4.09k stars 442 forks source link

Span Name changes for OTEL filter #9848

Open nfuden opened 2 months ago

nfuden commented 2 months ago

Gloo Edge Product

Open Source

Gloo Edge Version

1.17.0

Is your feature request related to a problem? Please describe.

Split from https://github.com/solo-io/gloo/issues/9313

In order to migrate from legacy tracing filters such as zipkin we should have a similar ux and make sure to be mostly compliant with OTEL spec. In this case Span name is set to "ingress" and does not comply with spec https://github.com/open-telemetry/opentelemetry-specification/blob/v1.33.0/specification/trace/api.md#span

Describe the solution you'd like

Contribute upstream a way to get more reasonable span names. Likely name is based on path but may need some extra steps such as a regex or something as the last piece of a path may be replaceable.

Describe alternatives you've considered

No response

Additional Context

No response

┆Issue is synchronized with this Asana task by Unito

nfuden commented 2 months ago

This likely is a blocker to https://github.com/solo-io/gloo/issues/9488

ashishb-solo commented 1 month ago

Design document link: ~https://soloio.slab.com/posts/open-telemetry-span-name-support-drlrm3c2#hnyrv-the-x-envoy-decorator-operation-header~

new design doc: https://soloio.slab.com/posts/open-telemetry-span-name-support-design-doc-t15kh24a

ashishb-solo commented 1 month ago

This likely is a blocker to https://github.com/solo-io/gloo/issues/9488

It is possible that it is not a blocker. https://github.com/solo-io/gloo/issues/9488 has to do with the tracer extension - that extension solely takes responsibility for converting the span to opentelemetry format and sending it to the collector. It should not take any responsibility for changing the contents of the span itself, so I don't think that we are going to end up making any changes in the opentelemetry tracer itself to implement this support - I could always be wrong though.

soloio-bot commented 1 month ago

Zendesk ticket #3478 has been linked to this issue.

ashishb-solo commented 1 month ago

Tracking progress updates for this in this document