solo-io / gloo

The Cloud-Native API Gateway and AI Gateway
https://docs.solo.io/
Apache License 2.0
4.09k stars 446 forks source link

glooctl check (version 1.17) does not honor exclude kube-gateway-classes kube-gateways #9874

Open pszeto opened 3 months ago

pszeto commented 3 months ago

Gloo Edge Product

Enterprise

Gloo Edge Version

1.17.0

Kubernetes Version

1.29

Describe the bug

glooctl check 1.17 includes a check for Kubernetes Gateway integration. This checks for an env var in the gloo deployment to see if kube gateway integration is enabled. During a normal check

glooctl check                                                                                                                                                                                                                                                                            
Checking Deployments... OK
Checking Pods... OK
Checking Upstreams... OK
Checking UpstreamGroups... OK
Checking AuthConfigs... OK
Checking RateLimitConfigs... OK
Checking VirtualHostOptions... OK
Checking RouteOptions... OK
Checking Secrets... OK
Checking VirtualServices... OK
Checking Gateways... OK
Checking Proxies... OK
Checking rate limit server... OK

Detected Kubernetes Gateway integration!
Checking Kubernetes GatewayClasses... OK
Checking Kubernetes Gateways... OK
Checking Kubernetes HTTPRoutes... OK

Detected Gloo Federation!
No problems detected.

However, when we tried to exclude kube-gateway-classes kube-gateways deployments kube-http-routes

glooctl check -x kube-gateway-classes -x kube-gateways -x pods -x deployments -x kube-http-routes                                                                                                                                                                           
Checking Upstreams... OK
Checking UpstreamGroups... OK
Checking AuthConfigs... OK
Checking RateLimitConfigs... OK
Checking VirtualHostOptions... OK
Checking RouteOptions... OK
Checking Secrets... OK
Checking VirtualServices... OK
Checking Gateways... OK
Checking Proxies... Skipping proxies because deployments were excluded
Skipping due to an error in checking deployments

Detected Kubernetes Gateway integration!

Detected Gloo Federation!
Error: 1 error occurred:
    * xds metrics check was skipped due to an error in checking deployments

It still has the Detected Kubernetes Gateway integration!. This can cause issues in some environment because the service-account need to do the check on the deployment not have enough permissions.

Expected Behavior

Steps to reproduce the bug

  1. run glooctl check -x kube-gateway-classes -x kube-gateways -x pods -x deployments -x kube-http-routes on 1.17

Additional Environment Detail

No response

Additional Context

No response

soloio-bot commented 3 months ago

Zendesk ticket #4279 has been linked to this issue.