glooctl check 1.17 includes a check for Kubernetes Gateway integration. This checks for an env var in the gloo deployment to see if kube gateway integration is enabled. During a normal check
glooctl check
Checking Deployments... OK
Checking Pods... OK
Checking Upstreams... OK
Checking UpstreamGroups... OK
Checking AuthConfigs... OK
Checking RateLimitConfigs... OK
Checking VirtualHostOptions... OK
Checking RouteOptions... OK
Checking Secrets... OK
Checking VirtualServices... OK
Checking Gateways... OK
Checking Proxies... OK
Checking rate limit server... OK
Detected Kubernetes Gateway integration!
Checking Kubernetes GatewayClasses... OK
Checking Kubernetes Gateways... OK
Checking Kubernetes HTTPRoutes... OK
Detected Gloo Federation!
No problems detected.
However, when we tried to exclude kube-gateway-classes kube-gateways deployments kube-http-routes
glooctl check -x kube-gateway-classes -x kube-gateways -x pods -x deployments -x kube-http-routes
Checking Upstreams... OK
Checking UpstreamGroups... OK
Checking AuthConfigs... OK
Checking RateLimitConfigs... OK
Checking VirtualHostOptions... OK
Checking RouteOptions... OK
Checking Secrets... OK
Checking VirtualServices... OK
Checking Gateways... OK
Checking Proxies... Skipping proxies because deployments were excluded
Skipping due to an error in checking deployments
Detected Kubernetes Gateway integration!
Detected Gloo Federation!
Error: 1 error occurred:
* xds metrics check was skipped due to an error in checking deployments
It still has the Detected Kubernetes Gateway integration!. This can cause issues in some environment because the service-account need to do the check on the deployment not have enough permissions.
Expected Behavior
When -x kube-gateway-classes -x kube-gateways -x kube-http-routes is used, it shouldn't check kube gateway resources at all.
When -x deployments is used, it should skip the kube gateway checks, similar to what we already do with proxies: Checking Proxies... Skipping proxies because deployments were excluded
Steps to reproduce the bug
run glooctl check -x kube-gateway-classes -x kube-gateways -x pods -x deployments -x kube-http-routes on 1.17
Gloo Edge Product
Enterprise
Gloo Edge Version
1.17.0
Kubernetes Version
1.29
Describe the bug
glooctl check 1.17 includes a check for Kubernetes Gateway integration. This checks for an env var in the gloo deployment to see if kube gateway integration is enabled. During a normal check
However, when we tried to exclude
kube-gateway-classes kube-gateways deployments kube-http-routes
It still has the
Detected Kubernetes Gateway integration!
. This can cause issues in some environment because the service-account need to do the check on the deployment not have enough permissions.Expected Behavior
-x kube-gateway-classes -x kube-gateways -x kube-http-routes
is used, it shouldn't check kube gateway resources at all.-x deployments
is used, it should skip the kube gateway checks, similar to what we already do with proxies:Checking Proxies... Skipping proxies because deployments were excluded
Steps to reproduce the bug
glooctl check -x kube-gateway-classes -x kube-gateways -x pods -x deployments -x kube-http-routes
on 1.17Additional Environment Detail
No response
Additional Context
No response