search

solo-io / go-utils

golang utilities
Apache License 2.0
112 stars 19 forks source link

Use lower case as is standard/recommended #268

Closed kdorosh closed 5 years ago

kdorosh commented 5 years ago

from the logrus readme:

Seeing weird case-sensitive problems? It's in the past been possible to import Logrus as both upper- and lower-case. Due to the Go package environment, this caused issues in the community and we needed a standard. Some environments experienced problems with the upper-case variant, so the lower-case was decided. Everything using logrus will need to use the lower-case: github.com/sirupsen/logrus. Any package that isn't, should be changed.

I was having numerous headaches trying to update the go-utils version in our rate limiting service, but after these changes (using https://github.com/solo-io/go-utils/pull/268/commits/44f8be641507b2ebac4fbb29738288d64fa54eed) I have no problem updating to the go-utils version in this commit hash. Oddly though, those changes prevent go mod tidy from working on go-utils itself -- requires more digging.

cc @EItanya @ilackarms BOT NOTES: resolves https://github.com/solo-io/go-utils/issues/269

solo-git-bot[bot] commented 5 years ago

Issues linked to changelog: https://github.com/solo-io/go-utils/issues/269

kdorosh commented 5 years ago

Other relevant docs: https://github.com/golang/go/wiki/Modules#how-can-i-resolve-parsing-gomod-unexpected-module-path-and-error-loading-module-requirements-errors-caused-by-a-mismatch-between-import-paths-vs-declared-module-identity

kdorosh commented 5 years ago

Ah, I think the current behavior is desired, although annoying, until helm>k8s>docker updates its dependency on capitalized Sirupsen