search

solo-io / go-utils

golang utilities
Apache License 2.0
110 stars 18 forks source link

Print bigger diff on ExpectEqualProtoMessages failure #282

Closed joekelley closed 4 years ago

joekelley commented 4 years ago

BOT NOTES: resolves https://github.com/solo-io/go-utils/issues/281

solo-git-bot[bot] commented 4 years ago

Issues linked to changelog: https://github.com/solo-io/go-utils/issues/281

joekelley commented 4 years ago

/test

joekelley commented 4 years ago

Closing as stale. I still like this idea in general, but there has been some resistance to printing huge strings when it's not obvious what the diff is.