Ensure release asset file is open before attempting upload in retry loop

solo-io / go-utils

golang utilities

Apache License 2.0

111 stars 19 forks source link

Ensure release asset file is open before attempting upload in retry loop #395

Closed kdorosh closed 4 years ago

kdorosh commented 4 years ago

Open and close the file within the retry loop so that if the github client closes it after an HTTP 500 failure, when we retry, the file is open before we attempt upload.

BOT NOTES: resolves https://github.com/solo-io/go-utils/issues/394

solo-changelog-bot[bot] commented 4 years ago

Issues linked to changelog: https://github.com/solo-io/go-utils/issues/394