solo-io / go-utils

golang utilities
Apache License 2.0
110 stars 18 forks source link

Build logger when an env var is set #451

Closed jahvon closed 3 years ago

jahvon commented 3 years ago

When setting the stat server log level via an environment variable. previously the log config was not being built so logs would not be produced. This also prevented logs from being produced when set via the admin api after the server started without a log config. This fix builds the log config so that the log level is applied and logs are produced.

Tested this locally with a gloo image that pulled in this change and a defined the env var.

solo-changelog-bot[bot] commented 3 years ago

Issues linked to changelog: https://github.com/solo-io/gloo/issues/4648