search

solo-io / go-utils

golang utilities
Apache License 2.0
110 stars 18 forks source link

securityscanutils: Only scan the latest patch version for a given minor release #479

Closed nfuden closed 2 years ago

nfuden commented 2 years ago

Make sec gen less noisy and faster BOT NOTES: resolves https://github.com/solo-io/go-utils/issues/478

solo-changelog-bot[bot] commented 2 years ago

Issues linked to changelog: https://github.com/solo-io/go-utils/issues/478

nfuden commented 2 years ago

Question: Do we feel that this should be gated with a flag? I think not as there is as far as I can tell no valid reason to be scanning old versions at least with how we handle cves but I defer to the reviewer.

jackstine commented 2 years ago

Question: Do we feel that this should be gated with a flag? I think not as there is as far as I can tell no valid reason to be scanning old versions at least with how we handle cves but I defer to the reviewer.

I think that having a flag would still defeat the purpose of the issue that was initially raised. I do not think we need a flag.

The code LGTM

nfuden commented 2 years ago

I thought about doing that but then was annoyed with the major minor combo check. Ill throw it in.

I verified it via gloo with a go workspace. Ill do the same with the new format of using a slice.

nfuden commented 2 years ago

Sooooo can has review?