search

solo-io / go-utils

golang utilities
Apache License 2.0
111 stars 19 forks source link

Remove context timeout #484

Closed chunter0 closed 2 years ago

chunter0 commented 2 years ago

BOT NOTES: resolves https://github.com/solo-io/go-utils/issues/486

solo-changelog-bot[bot] commented 2 years ago

Issues linked to changelog: https://github.com/solo-io/go-utils/issues/486

nfuden commented 2 years ago

Looks like its used in mesh currently but not in edge

I agree that it should be configurable but in general dialing without timeout is not safe in a production use case so it seems safest that we just add an option and then set the default to be 1 min if not configured.

EItanya commented 2 years ago

Agreed, I think an option makes sense, and if set to 0 it does nothing or something like that