solo-io / go-utils

golang utilities
Apache License 2.0
111 stars 19 forks source link

Improve Scanning Performance #488

Closed sam-heilbron closed 2 years ago

sam-heilbron commented 2 years ago

Describe

Our Trivy scans had a small bug wherein a scan would run and no matter what the result of the scan was, the scan would be rerun with an increasing delay causing each scan to take upwards of three minutes to run where a manual scan would have taken milliseconds/seconds, this caused our scans on multiple images each with multiple tagged versions to take upwards of six hours. We solved this by adding exit code checking logic in the executeScanWithRetries() function.

BOT NOTES: resolves https://github.com/solo-io/go-utils/issues/490

solo-changelog-bot[bot] commented 2 years ago

Issues linked to changelog: https://github.com/solo-io/go-utils/issues/490