solo-io / go-utils

golang utilities
Apache License 2.0
110 stars 18 forks source link

DocsGen failing with NPE #496

Closed bewebi closed 1 year ago

bewebi commented 1 year ago

The Docs action for Gloo has been failing due to a nil pointer dereference repeatedly, for example here and here

I have been unable to reproduce this locally or identify a bug through static code analysis

Until the bug is reproduced/identified we can return an error in this case rather than panic in order to better understand the failing behavior when it occurs

bewebi commented 1 year ago

This issue has arisen once since the fix was merged to error instead of panic

In that case the logged error was:

2022/08/10 14:02:28 unable to run: no release found for version ***Major:1 Minor:2 Patch:0 Label: LabelVersion:0***

(link)

It seems plausible, perhaps even likely, that the behavior will not occur once we stop processing exceedingly old versions which may have inconsistencies with regards to their ChangelogNotes.

This issue being closed since this particular failure seems to occur infrequently, including relative to other failures on the Docs action, and because a potential solution is scoped in another issue (#499)

Should the error recur after we stop processing older versions the issue should be reopened