solo-io / go-utils

golang utilities
Apache License 2.0
111 stars 19 forks source link

Ginkgo v2 #506

Closed sam-heilbron closed 1 year ago

sam-heilbron commented 1 year ago

Description

Upgrade ginkgo library to use v2

Context

Projects which consume go-utils in test code, require that go-utils depends on ginkgo-v2 before they can be upgraded

Pull Request GHA Changes

I updated the job trigger to run on pull requests to main. My intention is to change the default branch in this repo from master to main after this merges.

Our tests don't actually use a kube cluster, so I removed the setup to create a cluster and install kubectl

Our action used an old base image. I updated that. I also updated our gcloud setup as that broke on newer ubuntu versions.

Makefile

I added some make targets that will be easily consumable by devs. See make help for a list of useful targets:

help                                Output the self-documenting make targets
clean                               Clean any local assets
test                                Run tests in the {TEST_PKG}
test-with-coverage                  Run tests in the {TEST_PKG} with coverage

Testing

solo-changelog-bot[bot] commented 1 year ago

Issues linked to changelog: https://github.com/solo-io/gloo/issues/7222

jackstine commented 1 year ago

I found a reference that do not use v2 ginko/config

sam-heilbron commented 1 year ago

We're getting rate-limited on our Github client so tests are failing. These utilities are important to communicate directly wit hthe API so I'm not going to build any workaround for them.