search

solo-io / go-utils

golang utilities
Apache License 2.0
110 stars 18 forks source link

Fix testutils double import issue #514

Closed inFocus7 closed 1 year ago

inFocus7 commented 1 year ago

Removed double-importing of "github.com/pkg/errors" and the import of the non-v2 "github.com/onsi/ginkgo"

Context

Faced an error in solo-project's CI due to the v0.24.1 update.

Step #0 - "tests": Step #12 - "test": # github.com/solo-io/go-utils/testutils/exec
Step #0 - "tests": Step #12 - "test": /go/pkg/mod/github.com/solo-io/go-utils@v0.24.1/testutils/exec/cmd.go:13:2: ginkgo redeclared in this block
Step #0 - "tests": Step #12 - "test":   /go/pkg/mod/github.com/solo-io/go-utils@v0.24.1/testutils/exec/cmd.go:10:2: other declaration of ginkgo
Step #0 - "tests": Step #12 - "test": /go/pkg/mod/github.com/solo-io/go-utils@v0.24.1/testutils/exec/cmd.go:13:2: "github.com/onsi/ginkgo/v2" imported as ginkgo and not used
Step #0 - "tests": Step #12 - "test": /go/pkg/mod/github.com/solo-io/go-utils@v0.24.1/testutils/exec/cmd.go:14:2: errors redeclared in this block
Step #0 - "tests": Step #12 - "test":   /go/pkg/mod/github.com/solo-io/go-utils@v0.24.1/testutils/exec/cmd.go:11:2: other declaration of errors
Step #0 - "tests": Step #12 - "test": /go/pkg/mod/github.com/solo-io/go-utils@v0.24.1/testutils/exec/cmd.go:14:2: "github.com/pkg/errors" imported and not used
solo-changelog-bot[bot] commented 1 year ago

Issues linked to changelog: https://github.com/solo-io/gloo/issues/8164

inFocus7 commented 1 year ago

CI in solo-projects PR passed with this update 🍾