search

solo-io / packer-plugin-arm-image

Packer plugin for ARM images
Apache License 2.0
425 stars 104 forks source link

feat(map_image): Replaced kpartx with losetup #115

Closed eaglesemanation closed 3 years ago

eaglesemanation commented 3 years ago

Implementation for #113

losetup is part of util-linux and should be preinstalled on most of linux distributions

solo-build-bot[bot] commented 3 years ago

Waiting for approval from someone in the solo-io org to start testing.

yuval-k commented 3 years ago

@eaglesemanation thanks! I think this requires some manual testing, as current CI doesn't check image building; will give it a try tonight!

mikemorris commented 3 years ago

FWIW this breaks running the Standalone build on macOS, which does not include losetup or have it available via Homebrew - it may be possible to alternately use hdiutil on macOS instead?

Edit: at least this change is an issue, but even reverting this I'm still not able to get this running via any method in the README (Vagrant, Docker or Standalone) on macOS. I did have this running successfully ~a year ago and was able to flash a Raspberry PI with an image build from a sample file, at some point prior to the repo rename from packer-builder-arm-image, not quite sure yet all of what's broken as it looks like there have been some substantial changes. git bisect or rewinding through commit history to find a breaking point has not been particularly helpful due to some of the remote dependencies which are now gone.

The Vagrant workflow seems to be failing on https://github.com/hashicorp/vagrant/issues/12557#issuecomment-958183899 for me, so not necessarily a problem with this project - haven't tracked down why the Docker build is failing yet.

Edit (2021-12-27): Vagrant workflow no longer seems blocked on the above issue after upgrading the VirtualBox v6.1.30, but both the Vagrant and Docker builds are now failing with the issue described in #124