search

solo-io / solo-kit

Toolkit for developing stateless, event-driven, declarative API systems
Apache License 2.0
69 stars 14 forks source link

Canary Status Reporting #529

Closed sam-heilbron closed 1 year ago

sam-heilbron commented 1 year ago

Description

We do not support multiple namespaces on a resource as would exist in a canary upgrade

Context

https://github.com/solo-io/solo-kit/blob/master/pkg/api/shared/status.go#L70

We need to remove this check. It's intended to ensure that there is only 1 status on the resource ,but in reality we may have multiple, when multiple controllers are reading the same resources.

Slack context: https://solo-io-corp.slack.com/archives/CEDCS8TAP/p1670354796059129

We should use https://github.com/solo-io/solo-kit/blob/master/pkg/utils/statusutils/env.go#L11 to determine which status entry in the map to modify.

Definition of Done

jenshu commented 1 year ago

possibly related https://github.com/solo-io/gloo/issues/7731

jenshu commented 1 year ago

fix available in Gloo EE 1.14.0-beta4, 1.13.5, 1.12.46, and 1.11.51