solo-io / squash

The debugger for microservices
https://squash.solo.io
Apache License 2.0
1.74k stars 102 forks source link

squashctl --container should be the container's name, not image #159

Closed Harwayne closed 5 years ago

Harwayne commented 5 years ago

The --container flag on squashctl is described as 'Container to debug', which implies to me that it is the name of the container, not the image.

The code uses that flag's value as Squash.Container here. It then sets DebugTarget.Container based on Squash.Container. The corresponding code for interactive choosing containers are here and here, both have Squash.Container set to the container's name, not its image.