search

solo-io / squash

The debugger for microservices
https://squash.solo.io
Apache License 2.0
1.74k stars 103 forks source link

upgrading k8s client-go to 1.14.3 to fix deployment for aws eks #227

Closed ageekymonk closed 3 months ago

ageekymonk commented 5 years ago

This fixes #226

solo-git-bot[bot] commented 5 years ago

Waiting for approval from someone in the solo-io org to start testing.

mitchdraft commented 5 years ago

/test

mitchdraft commented 5 years ago

@ageekymonk thanks for putting this together. Looks like the skaffold api changed with the version bump:

Step #8 - e2e-test": # github.com/solo-io/squash/vendor/github.com/GoogleContainerTools/skaffold/pkg/skaffold/kubernetes
Step #8 - "e2e-test": vendor/github.com/GoogleContainerTools/skaffold/pkg/skaffold/kubernetes/log.go:72:3: unknown field 'IncludeUninitialized' in struct literal of type "github.com/solo-io/squash/vendor/k8s.io/apimachinery/pkg/apis/meta/v1".ListOptions
Step #8 - "e2e-test": vendor/github.com/GoogleContainerTools/skaffold/pkg/skaffold/kubernetes/wait.go:44:4: unknown field 'IncludeUninitialized' in struct literal of type "github.com/solo-io/squash/vendor/k8s.io/apimachinery/pkg/apis/meta/v1".GetOptions
Step #8 - "e2e-test": vendor/github.com/GoogleContainerTools/skaffold/pkg/skaffold/kubernetes/wait.go:59:4: unknown field 'IncludeUninitialized' in struct literal of type "github.com/solo-io/squash/vendor/k8s.io/apimachinery/pkg/apis/meta/v1".GetOptions
Step #8 - "e2e-test": vendor/github.com/GoogleContainerTools/skaffold/pkg/skaffold/kubernetes/wait.go:80:4: unknown field 'IncludeUninitialized' in struct literal of type "github.com/solo-io/squash/vendor/k8s.io/apimachinery/pkg/apis/meta/v1".GetOptions
Step #8 - "e2e-test": vendor/github.com/GoogleContainerTools/skaffold/pkg/skaffold/kubernetes/wait.go:193:11: undefined: watch.Until
Step #8 - "e2e-test": vendor/github.com/GoogleContainerTools/skaffold/pkg/skaffold/kubernetes/wait.go:223:11: undefined: watch.Until
Step #8 - "e2e-test": 
Step #8 - "e2e-test":

Let me know when you'd like to run the ci again

Even if you don't have your env set up to run the e2e you should be able to reproduce this by triggering the e2e: ginkgo -r -failFast

mitchdraft commented 5 years ago

/kick

mitchdraft commented 5 years ago

/test

mitchdraft commented 5 years ago

@ageekymonk could you change the target cluster to "squash-test" in https://github.com/solo-io/squash/blob/master/cloudbuild.yaml#L87 I think the test-cluster might be out of date

mitchdraft commented 5 years ago

/test