search

solo-io / unik

The Unikernel & MicroVM Compilation and Deployment Platform
Apache License 2.0
2.72k stars 191 forks source link

Refactor OSv compiler #111

Closed miha-plesko closed 7 years ago

miha-plesko commented 8 years ago

OSv compiler needed some changes to match Rumprun compiler structure better. Prior this change, OSv compiler had a reversed logic compared to Rumprun. Fixed.

miha-plesko commented 8 years ago

Mr @ilackarms , Mr @gberginc, as suggested in other PR the OSv compiler refactoring is now sitting in this separate PR. I kindly ask for a review.

miha-plesko commented 8 years ago

I'd suggest to review this PR by examining directory structure and files inside pkg/compilers/osv, not the diff. Diff is ugly since I've moved some files and reorganized some functions, but the result is really neat to read IMHO.

miha-plesko commented 7 years ago

Hello, does this refactoring seem reasonable to you guys? 😄

gberginc commented 7 years ago

Hey, sorry @miha-plesko. I didn't know who you were addressing with Mr :). I'll take a look.

miha-plesko commented 7 years ago

I'd be happy to see Capstan integration converging towards merge, if possible. I've rebased the PR to the latest master and dropped changing directory structure to simplify the review.

@ilackarms, @gberginc, gentlemen, I would kindly ask you for a review.