Integrate forked Capstan

solo-io / unik

The Unikernel & MicroVM Compilation and Deployment Platform

Apache License 2.0

2.71k stars 191 forks source link

Integrate forked Capstan #118

Closed miha-plesko closed 7 years ago

miha-plesko commented 7 years ago

Added support for forked Capstan tool. User can now create OSv unikernels using precompiled packages.

There are three configuration files available:

$PROJECT_ROOT/meta/run.yaml (application structure description)
$PROJECT_ROOT/meta/package.yaml (list of required packages)
$PROJECT_ROOT/manifest.yaml (additional parameters for Capstan) Only the first one is required, other two are optional.

Signed-off-by: Miha Pleško miha.plesko@xlab.si

miha-plesko commented 7 years ago

Dear @ilackarms, dear @gberginc, I've managed to prepare the forked Capstan integration at last! :champagne:

I realize that the PR is quite large, but I think it's easiest to show you the whole story at once. I've followed the steps that we've specified on the videocall so you should probably be able to understand the code.

I'm looking forward to your comments.

PS: Below please find examples for each of the languages that the forked Capstan provides: forked-capstan-examples.zip

miha-plesko commented 7 years ago

He-yo, 2017 up-and-running, hope you're all doing well back there at EMC! 😄 Does this look somewhat what we wanted to have?

ilevine commented 7 years ago

We have been busy with the holiday and the new year. We will get to reviewing this PR soon. Sorry for the delay

ilevine commented 7 years ago

Please make sure to add appropriate targets to the Makefile for the new container/compiler you've added to unik
Having a large set of changes all contained in a single commit makes it difficult for us to reason through the code. We strongly suggest splitting future changes into smaller commits (such that each commit allows unik to compile), where the new feature is integrated into the cli/daemon only in the last commit.

miha-plesko commented 7 years ago

Thanks for the response, @ilevine. I've split the PR into 6 smaller commits and added Makefile target for the new container.

As you can see, I've taken liberty to fully replace existing OSv integration with the new one (so that only one implementation of Capstan will be used once we merge this). I'm looking forward to be hearing your opinion on this. Should it bother you too much, I'll try to find a way to keep both integrations.

ilevine commented 7 years ago

closing this PR with respect to the new one that was submitted in its place