search

solo-io / unik

The Unikernel & MicroVM Compilation and Deployment Platform
Apache License 2.0
2.72k stars 191 forks source link

Make build fails on Mac High Sierra 10.13.6 #179

Closed gokalper closed 5 years ago

gokalper commented 5 years ago

Not sure what causes it to fail but here is the output that shows errors:


pkg/providers/firecracker/delete_instance.go:4:10: p.StopInstance undefined (type *FirecrackerProvider has no field or method StopInstance)
pkg/providers/firecracker/get_image.go:9:24: cannot use p (type *FirecrackerProvider) as type providers.Provider in argument to common.GetImage:
    *FirecrackerProvider does not implement providers.Provider (missing StopInstance method)
pkg/providers/firecracker/get_instance.go:9:27: cannot use p (type *FirecrackerProvider) as type providers.Provider in argument to common.GetInstance:
    *FirecrackerProvider does not implement providers.Provider (missing StopInstance method)
pkg/providers/firecracker/get_volume.go:9:25: cannot use p (type *FirecrackerProvider) as type providers.Provider in argument to common.GetVolume:
    *FirecrackerProvider does not implement providers.Provider (missing StopInstance method)
pkg/providers/firecracker/run_instance.go:43:34: cannot use p (type *FirecrackerProvider) as type providers.Provider in argument to common.VerifyMntsInput:
    *FirecrackerProvider does not implement providers.Provider (missing StopInstance method)
github.com/solo-io/unik/vendor/github.com/vmware/govmomi/vim25/types
github.com/solo-io/unik/pkg/providers/virtualbox
github.com/solo-io/unik/vendor/github.com/vmware/govmomi/vim25/xml
net/http/cookiejar
github.com/solo-io/unik/pkg/providers/xen/xenclient
github.com/solo-io/unik/pkg/providers/xen
encoding/csv
github.com/solo-io/unik/vendor/github.com/spf13/pflag
github.com/solo-io/unik/vendor/github.com/spf13/cobra
github.com/solo-io/unik/pkg/providers/gcloud
github.com/solo-io/unik/vendor/github.com/vmware/govmomi/vim25/soap
github.com/solo-io/unik/vendor/github.com/vmware/govmomi/vim25/methods
github.com/solo-io/unik/vendor/github.com/vmware/govmomi/vim25/mo
github.com/solo-io/unik/vendor/github.com/vmware/govmomi/vim25
github.com/solo-io/unik/vendor/github.com/vmware/govmomi/property
github.com/solo-io/unik/vendor/github.com/vmware/govmomi/list
github.com/solo-io/unik/vendor/github.com/vmware/govmomi/task
github.com/solo-io/unik/vendor/github.com/vmware/govmomi/session
github.com/solo-io/unik/vendor/github.com/vmware/govmomi
github.com/solo-io/unik/vendor/github.com/vmware/govmomi/object
github.com/solo-io/unik/vendor/github.com/vmware/govmomi/find
github.com/solo-io/unik/pkg/providers/vsphere/vsphereclient
github.com/solo-io/unik/pkg/providers/vsphere
Makefile:263: recipe for target 'localbuild' failed
make: *** [localbuild] Error 2
make: *** [binary] Error 2```
urjitbhatia commented 5 years ago

@gokalper I have opened a PR with the fix

yuval-k commented 5 years ago

Thanks! closing as fixed