support TinyGo SDK - Githubissues

solo-io / wasm

Web Assembly tools and SDKs for extending cloud-native infrastructure

Apache License 2.0

305 stars 39 forks source link

support TinyGo SDK #189

Closed mathetake closed 4 years ago

mathetake commented 4 years ago

Hi folks, I am the author of TinyGo SDK and I am thinking of adding the support of TinyGo SDK in wasme since It's now compatible istio/envoy with 1.7.x as of its 0.0.3 release.

~This is still in WIP but I need the direction from the maintainers here to add the build command support for TinyGo SDK.~

Thanks!

resolves https://github.com/solo-io/wasm/issues/31 ?

solo-build-bot[bot] commented 4 years ago

Waiting for approval from someone in the solo-io org to start testing.

yuval-k commented 4 years ago

look good! are you able to add an e2e similar to this one?

https://github.com/solo-io/wasm/blob/cc1968997db6e1efd3f0bc6a6cc67ac1a5dac540/tools/wasme/cli/test/e2e/build/build_test.go#L130

This will help us to catch regressions when istio 1.8 will be out.

yuval-k commented 4 years ago

as for the build command, the details are as follows:

update the build container to have your build tools: tools/wasme/cli/builder/Dockerfile
add a build subcommand: tools/wasme/cli/pkg/cmd/build/go.go that runs your build see runBuild function

(see an example with rust here: https://github.com/solo-io/wasm/commit/911d0085bce78838de883f5aa54332de79458302)

mathetake commented 4 years ago

@yuval-k Thank you for comments, and now I think it's ready for review! PTAL :smile:

yuval-k commented 4 years ago

thank you!