search

solo-io / wasm

Web Assembly tools and SDKs for extending cloud-native infrastructure
Apache License 2.0
305 stars 39 forks source link

Use apiextensions.k8s.io/v1 CustomResourceDefinition in the crd manifest. #215

Open ryysud opened 3 years ago

ryysud commented 3 years ago

Describe the bug

This issue is the improvement, not the bug.

To Reproduce

When I apply the latest crd manifest to k8s v1.19.0, A warning is printed.

$ kubectl apply -f https://github.com/solo-io/wasm/releases/download/v0.0.28/wasme.io_v1_crds.yaml
Warning: apiextensions.k8s.io/v1beta1 CustomResourceDefinition is deprecated in v1.16+, unavailable in v1.22+; use apiextensions.k8s.io/v1 CustomResourceDefinition
customresourcedefinition.apiextensions.k8s.io/filterdeployments.wasme.io created

Expected behavior

Use apiextensions.k8s.io/v1 CustomResourceDefinition in the crd manifest.

Additional context

N/A

Sodman commented 3 years ago

This is something we'll need to address. We need to think about the upgrade path, too. Similar changes will also be required in gloo.