search

solo-io / wasm

Web Assembly tools and SDKs for extending cloud-native infrastructure
Apache License 2.0
305 stars 39 forks source link

Support Istio 1.9 as a deployment target #239

Closed Sodman closed 3 years ago

Sodman commented 3 years ago

Is your feature request related to a problem? Please describe. Istio 1.9.0 was released this week. We should add support for this version in wasme.

Describe the solution you'd like If the underlying wasm ABI has not changed in the Envoy version being used by istio proxy under the hood, then we just need to update the version check logic (this was the case when adding istio 1.8 support).

If the ABI has changed, we'll need to build a new example filter for istio in each of the 4 supported languages (cpp, assemblyScript, rust and tinyGo), so that wasme init will still work as expected for images targeting istio 1.9.

Describe alternatives you've considered Users can use the --ignore-version-check flag to bypass the version check when deploying to Istio. Eg: wasme deploy istio webassemblyhub.io/my-username/my-image:v1.0 --id my-filter --ignore-version-check

Additional context PR to add Istio 1.8 support is here for reference.

swartz-k commented 3 years ago

Hey, Can assign it to me? As We are running istio 1.9 on production env and looking forward to working with it with wasm.

Sodman commented 3 years ago

Sure thing, appreciate the contribution! I believe it should be similar to the Istio 1.8.x PR mentioned above!

Sodman commented 3 years ago

Implemented by https://github.com/solo-io/wasm/pull/244