search

solo-io / wasm

Web Assembly tools and SDKs for extending cloud-native infrastructure
Apache License 2.0
306 stars 40 forks source link

wasme deploy fails when configuration contains zipkin config #261

Closed asayah closed 3 years ago

asayah commented 3 years ago

add: 

spec:
  bindAddress: '::'
  bindPort: 8080
  httpGateway:
    options:
      httpConnectionManagerSettings:
        tracing:
          verbose: true
          requestHeadersForTags:
            - path
            - origin
          zipkinConfig:
            collectorEndpoint: /api/v2/spans
            collectorEndpointVersion: HTTP_JSON
            collectorUpstreamRef:
              name: zipkin
              namespace: default
  proxyNames:
  - gateway-proxy
  ssl: false

then 

--- ~ » wasme deploy gloo webassemblyhub.io/asayah/add-header:v0.2 --id=add-header                                                                                                                                                    130 ↵
Error: All attempts fail:
#1: converting output crd: reading crd spec on resource gateway-proxy in namespace gloo-system into v1Gateway: unknown field "zipkinConfig" in tracing.ListenerTracingSettings
Sodman commented 3 years ago

What versions of Gloo & wasme were you using when you hit this? Looks like we just need to bump the gloo dependency to something newer, as wasme is missing the new fields.

Sodman commented 3 years ago

Will also be fixed when https://github.com/solo-io/wasm/issues/257 is done, same root cause, closing as duplicate.