tanjunchen commented 3 years ago

Description

Please include a summary of the changes.

This bug fixes ... \ This new feature can be used to ...

Context

Users ran into this bug doing ... \ Users needed this feature to ...

[ ] I included a concise, user-facing changelog (for details, see https://github.com/solo-io/go-utils/tree/master/changelogutils) which references the issue that is resolved.
[ ] If I updated APIs (our protos) or helm values, I ran make install-deps operator-gen generated-code from tools/wasme/cli to ensure there will be no code diff
[ ] I followed guidelines laid out in the Gloo contribution guide
[ ] I opened a draft PR or added the work in progress label if my PR is not ready for review
[ ] I have performed a self-review of my own code
[ ] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[ ] I have added tests that prove my fix is effective or that my feature works

solo-build-bot[bot] commented 3 years ago

Waiting for approval from someone in the solo-io org to start testing.

tanjunchen commented 3 years ago

/cc @Sodman