tanjunchen commented 3 years ago

Description

Please include a summary of the changes.

This bug fixes ... \ This new feature can be used to ...

Context

Users ran into this bug doing ... \ Users needed this feature to ...

Checklist:

[ ] I included a concise, user-facing changelog (for details, see https://github.com/solo-io/go-utils/tree/master/changelogutils) which references the issue that is resolved.
[ ] If I updated APIs (our protos) or helm values, I ran make install-deps operator-gen generated-code from tools/wasme/cli to ensure there will be no code diff
[ ] I followed guidelines laid out in the Gloo contribution guide
[ ] I opened a draft PR or added the work in progress label if my PR is not ready for review
[ ] I have performed a self-review of my own code
[ ] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[ ] I have added tests that prove my fix is effective or that my feature works

solo-build-bot[bot] commented 3 years ago

Waiting for approval from someone in the solo-io org to start testing.

tanjunchen commented 3 years ago

/cc @Sodman

asayah commented 3 years ago

@tanjunchen thanks for the PR, it will be reviewed soon by the dev team.

ilackarms commented 3 years ago

/test

tanjunchen commented 3 years ago

@jehawley hello, could you help me pass these checks?

tanjunchen commented 2 years ago

/retest

kdorosh commented 2 years ago

/test

EItanya commented 2 years ago

hello @tanjunchen, sorry for the back and forth, but I think we have solved the issue, could you please push another commit. We enabled forked actions at the org level and tested it elsewhere so we are confident. Thanks

tanjunchen commented 2 years ago

hello @tanjunchen, sorry for the back and forth, but I think we have solved the issue, could you please push another commit. We enabled forked actions at the org level and tested it elsewhere so we are confident. Thanks

@EItanya done

tanjunchen commented 2 years ago

/retest

tanjunchen commented 2 years ago

/retest

asayah commented 2 years ago

The tests failed, I restarted them

Sodman commented 2 years ago

Possible issue with CI, as there has been no meaningful code changes since the last few commits to master, all of which passed.

Seeing in the logs the istio install appears to be timing out. I'll try look into this today.

Sodman commented 2 years ago

Hi @tanjunchen it turns out the latest version of KinD isn't compatible with the older Istio versions used in this test suite. I've just merged a PR to master to fix this and CI should be working again with latest. If you grab latest with master into this PR then everything should start running in CI properly. Thanks for your patience!

tanjunchen commented 2 years ago

Hi @tanjunchen it turns out the latest version of KinD isn't compatible with the older Istio versions used in this test suite. I've just merged a PR to master to fix this and CI should be working again with latest. If you grab latest with master into this PR then everything should start running in CI properly. Thanks for your patience!

done

tanjunchen commented 2 years ago

/retest

Sodman commented 2 years ago

I've kicked the tests a few times but 1.10 and 1.11 seem to be failing consistently. Have you tested running a wasm plugin with this code on these Istio versions locally?

Looks like it's receiving a HTTP 503 when trying to send requests to bookinfo after the wasm filter is applied. This is the error from the logs:

• Failure [303.656 seconds]
skv2Generate
/home/runner/work/wasm/wasm/tools/wasme/cli/test/e2e/operator/happy_path_e2e_test.go:150
  runs the wasme operator [It]
  /home/runner/work/wasm/wasm/tools/wasme/cli/test/e2e/operator/happy_path_e2e_test.go:151

  Timed out after 300.074s.
  Expected
      <string>:   % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                       Dload  Upload   Total   Spent    Left  Speed

  0     0    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     0*   Trying 10.96.57.231:9080...
      * TCP_NODELAY set
      * Connected to details.bookinfo (10.96.57.231) port 9080 (#0)
      > GET /details/123 HTTP/1.1
      > Host: details.bookinfo:9080
      > User-Agent: curl/7.68.0
      > Accept: */*
      > 
      * Mark bundle as not supporting multiuse
      < HTTP/1.1 503 Service Unavailable
      < date: Thu, 16 Dec 2021 15:25:11 GMT
      < server: istio-envoy
      < x-envoy-decorator-operation: details.bookinfo.svc.cluster.local:9080/*
      < content-length: 0
      < 

  0     0    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     0
      * Connection #0 to host details.bookinfo left intact

  to contain substring
      <string>: hello: world

  /home/runner/work/wasm/wasm/tools/wasme/cli/test/e2e/operator/happy_path_e2e_test.go:183

tanjunchen commented 2 years ago

I've kicked the tests a few times but 1.10 and 1.11 seem to be failing consistently. Have you tested running a wasm plugin with this code on these Istio versions locally?

Looks like it's receiving a HTTP 503 when trying to send requests to bookinfo after the wasm filter is applied. This is the error from the logs:

I've kicked the tests a few times but 1.10 and 1.11 seem to be failing consistently. Have you tested running a wasm plugin with this code on these Istio versions locally?

Looks like it's receiving a HTTP 503 when trying to send requests to bookinfo after the wasm filter is applied. This is the error from the logs:
• Failure [303.656 seconds]
skv2Generate
/home/runner/work/wasm/wasm/tools/wasme/cli/test/e2e/operator/happy_path_e2e_test.go:150
  runs the wasme operator [It]
  /home/runner/work/wasm/wasm/tools/wasme/cli/test/e2e/operator/happy_path_e2e_test.go:151

  Timed out after 300.074s.
  Expected
      <string>:   % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                       Dload  Upload   Total   Spent    Left  Speed

  0     0    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     0*   Trying 10.96.57.231:9080...
      * TCP_NODELAY set
      * Connected to details.bookinfo (10.96.57.231) port 9080 (#0)
      > GET /details/123 HTTP/1.1
      > Host: details.bookinfo:9080
      > User-Agent: curl/7.68.0
      > Accept: */*
      > 
      * Mark bundle as not supporting multiuse
      < HTTP/1.1 503 Service Unavailable
      < date: Thu, 16 Dec 2021 15:25:11 GMT
      < server: istio-envoy
      < x-envoy-decorator-operation: details.bookinfo.svc.cluster.local:9080/*
      < content-length: 0
      < 

  0     0    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     0
      * Connection #0 to host details.bookinfo left intact

  to contain substring
      <string>: hello: world

  /home/runner/work/wasm/wasm/tools/wasme/cli/test/e2e/operator/happy_path_e2e_test.go:183

I tested 1.11 locally. It's OK locally. I will try to test e2e locally. It's not clear whether this is related to the OCI image used in the test.

EItanya commented 2 years ago

@tanjunchen are you using a different image locally? I think the ABI changed recently

tanjunchen commented 2 years ago

@tanjunchen are you using a different image locally? I think the ABI changed recently

yes, I use my local image not the case ueds in e2e test.

13567436138 commented 2 years ago

when will this version be released？？

solo-io / wasm

support istio 1.10.x and 1.11.x #274

Description

Context

Checklist: