search

solo-io / workshops

Apache License 2.0
127 stars 72 forks source link

TokenRequest feature gate no longer relevant in 1.21 #37

Open day0ops opened 3 years ago

day0ops commented 3 years ago

Looks like TokenRequest feature gate in 1.21 has been promoted as mentioned in changelog so no longer relevant.

This change impacts control planes created for new clusters. Leads to error

May 20 04:22:08 kind1-control-plane kubelet[290]: E0520 04:22:08.186018     290 server.go:216] "Failed to set feature gates from initia
l flags-based config" err="unrecognized feature gate: TokenRequest"

Either we should put a pre-req or fix the deploy.sh to take this into account.

day0ops commented 3 years ago

cc @linsun ... happy to raise a PR for this

linsun commented 3 years ago

@djannot I think you have fixed this yesterday in the deploy.sh?