soloam / ha-pid-controller

PID Controller to Home Assistant

MIT License

97 stars 12 forks source link

Breaking update 1.1.3 and how to tune? #13

Closed RubenKelevra closed 2 years ago

RubenKelevra commented 2 years ago

11 changed the info on p/i/d as they are now only allowed to be between 0 and 1.

So how are we supposed to tune the algorithm now? Following the Calibrate the PID section, we probably always have values greater than 1.

This is also a breaking change which isn't mentioned in the v1.1.3 release nodes.

Do old configurations still work with 1.1.3? I mean, the p/i/d values are out of the allowed range now.

soloam commented 2 years ago

Yehhh added that info because I was working on the auto tune, and was thinking on a way to make this usable in all situations! And the idea was to make it with value's based on percentage! Actually there is no limitations on that fields! I will remove that info because it's not true!

Actually nothing changed in this version, only some tweaks too make it more clean in the code and more reliable!

Sorry about the confusion!

RubenKelevra commented 2 years ago

Ah! No worries, I was just a bit confused. Thanks for the fast answer! :)