search

solokeys / solo1-cli

Solo 1 library and CLI in Python
https://pypi.org/project/solo-python
Apache License 2.0
183 stars 69 forks source link

Change Makefile to work with isort version 5 #101

Closed enrikb closed 3 years ago

enrikb commented 3 years ago

Just noticed that some of the make targets did not work well on a fresh checkout and init. Seems to be related to isort version 5 differences. This PR tries to fix the inconsistencies.

nickray commented 3 years ago

Thanks!

Want to require >= this version 5 in dev-requirements, in case this is a new option? Otherwise someone with an older version will complain :)

And can you add an entry to CHANGELOG under the unreleased section?

enrikb commented 3 years ago

Sure, makes sense. The -y option actually makes isort versions >= 5.0.0 fail, so it can't be kept for users of older versions without additional effort.