search

solokeys / solo1-cli

Solo 1 library and CLI in Python
https://pypi.org/project/solo-python
Apache License 2.0
183 stars 69 forks source link

Allow interactive PIN entry for `solo key verify`. #102

Closed enrikb closed 3 years ago

enrikb commented 3 years ago

While still allowing to pass --pin <pin> like some of the other commands, do no longer suggest it.

The solution is a bit hacky, calling verify recursively a second time iff a PIN is required but was not set before.

The 'Please press the button on your Solo key' is also not very consistently repeated, but it is also output a little inconsistently before this change.

enrikb commented 3 years ago

Reworked to use FIDO2 info indication to tell if PIN is required.