search

solokeys / solo1-cli

Solo 1 library and CLI in Python
https://pypi.org/project/solo-python
Apache License 2.0
182 stars 69 forks source link

solo-python 0.0.28 still references pre 0.9 python-fido call `InternalSend()` #126

Closed enrikb closed 3 years ago

enrikb commented 3 years ago

https://github.com/solokeys/solo-python/blob/826c784a20e35e3ef0aa52a482c2b9157d8248ce/solo/devices/solo_v1.py#L108

enrikb commented 3 years ago

See also https://github.com/solokeys/solo/issues/544

enrikb commented 3 years ago

I replaced the old with a new experimental workaround: https://github.com/enrikb/solo-python/commit/639f44872df5e4c93844c678f10a522ff4eeea4b

Successfully tested using a Solo hacker.

conorpp commented 3 years ago

Thanks again @enrikb! I tested on my end and it seems to work well. Making a new release now.