solokeys / solo1-cli

Solo 1 library and CLI in Python
https://pypi.org/project/solo-python
Apache License 2.0
182 stars 69 forks source link

Add pin argument to make-credential #133

Closed HeroicKatora closed 3 years ago

HeroicKatora commented 3 years ago

This fixes an issue where a device with a set pin can not run the make-credential command as the pin is not forwarded to fido2.

nickray commented 3 years ago

That's an odd oversight, not sure why it didn't come up before. Thanks!