search

solokeys / solo1-cli

Solo 1 library and CLI in Python
https://pypi.org/project/solo-python
Apache License 2.0
182 stars 69 forks source link

transition to fido2 1.0.0 and higher #157

Open vladak opened 2 years ago

vladak commented 2 years ago

Discussed in https://github.com/solokeys/solo1-cli/discussions/156

Originally posted by **vladak** June 23, 2022 solo1-cli version 0.1.1 (with changes matching PR #153), and brand new Solokey with updated firmware: ``` $ solo1 ls :: Solos None: SoloKeys Solo 4.1.5 ``` and it is not possible to change the default PIN: ``` $ solo1 key change-pin Please enter old pin: Please enter new pin: Please confirm new pin: 'Fido2Client' object has no attribute 'client_pin' $ solo1 key set-pin Please enter new pin: Please confirm new pin: 'Fido2Client' object has no attribute 'client_pin' ``` I installed the `solo1` via the usual means (Python venv + pip install). The `fido2` package is at version 1.0.0.
vladak commented 2 years ago

This is not the only problem with using fido2 1.0.0 (see the related discussion), so I changed the bug synopsis.

AlexNigl commented 1 year ago

A quick fix would be to pin the fido2 version to 0.9.x see https://github.com/solokeys/solo1-cli/pull/159 This would fix the currently broken "pip install solo1" installation.

prusnak commented 1 year ago

Possible fixes in https://github.com/trustcrypto/onlykey-solo-python/commit/7e570dc0f7292eded4644f4eb637e22308aebd91 (files solo/devices/base.py, solo/devices/solo_v1.py, solo/solotool.py)

mcepl commented 11 months ago

Possible fixes in trustcrypto@7e570dc (files solo/devices/base.py, solo/devices/solo_v1.py, solo/solotool.py)

There are not, this is just a subset of #159 and pretty poorly done (removing some files and adding some others without a reason).

innir commented 8 months ago

@nickray @kms15 any update on the fido2 >= 1.0 transition. Debian would like to get fido2 1.1 in and solo1-cli is currently blocking.

innir commented 8 months ago

I started working on this now in PR #169 - it's very much WIP. Please test & report breakages as I don't really have an idea how to systematically test ...

innir commented 7 months ago

@nickray If you don't act now, this will kick solo1-cli out of Debian, Ubuntu and all their downstream distros unfortunately.

fabaff commented 1 month ago

...will kick solo1-cli out of Debian, Ubuntu and all their downstream distros unfortunately.

The same applies for NIxpkgs.

innir commented 1 month ago

@fabaff You could use PR #169. This version is in Debian testing for six months now without bug reports.