Unexpected 0x41 markers added during merge

solokeys / solo1-cli

Solo 1 library and CLI in Python

https://pypi.org/project/solo-python

Apache License 2.0

185 stars 69 forks source link

Unexpected 0x41 markers added during merge #31

Closed szszszsz closed 4 years ago

szszszsz commented 5 years ago

Hi!

While working on https://github.com/solokeys/solo/pull/238 I have noticed a 0x41 marker on the APPLICATION_END_PAGE boundary, introduced during the all.hex merge. Is it needed anywhere, or is it just for debug purposes (e.g. to hand-check firmware dump)?

https://github.com/solokeys/solo-python/blob/e2a81a2c39bef61f98dca29154c5fdedff3a1044/solo/operations.py#L68-L69

conorpp commented 5 years ago

I believe those were there originally for debugging purposes yes. I can't find or remember any other reason.

szszszsz commented 5 years ago

OK! Let them be. Perhaps it would be worth making a comment to the setting lines in solo-python about their purpose. This will make the ticket actionable.

nickray commented 4 years ago

Closing for inactivity.