Ensure compatibility with python-fido2 0.8 (fixes #49)

solokeys / solo1-cli

Solo 1 library and CLI in Python

https://pypi.org/project/solo-python

Apache License 2.0

185 stars 69 forks source link

Ensure compatibility with python-fido2 0.8 (fixes #49) #51

Closed windmueller closed 4 years ago

windmueller commented 4 years ago

The Timeout has been removed from python-fido2 in version 0.8.

nickray commented 4 years ago

This is the new blessed way, yes? Would replace https://github.com/solokeys/solo-python/pull/47

windmueller commented 4 years ago

As I wrote in #49, Python is not my primary programming language. However, I tried to make the same adjustments as the authors of the library in the respective commit (Yubico/python-fido2@4c48977173fd32f70e61f518c7624558ffe54b9c).

Please accept one of the pull requests and create a new release. Right now this package is broken for distributions shipping the new fido2 library, like Arch.

nickray commented 4 years ago

Had some minor nits:

import order incorrect (make check and make fix to the rescue)
missing CHANGELOG.md entry
missing solo/VERSION bump

I did add these and published an update on PyPI.

Thanks for your contribution!