search

solokeys / solo1-cli

Solo 1 library and CLI in Python
https://pypi.org/project/solo-python
Apache License 2.0
183 stars 69 forks source link

extend PIN support #72

Closed My1 closed 4 years ago

My1 commented 4 years ago

Add PIN support for make-credential and challenge-response

My1 commented 4 years ago

if possible it might be nice to replace the "leave empty for no PIN" part with a check whether a PIN exists on the key (if possible) and then if no PIN provided, to not even send the command over

conorpp commented 4 years ago

Thank you!

Yes, if a PIN is set, this can be seen in the CTAP2 info which can be collected immediately before makeCredential. So that would be a good enhancement to use.

My1 commented 4 years ago

this is great. I have something ready locally just need to get that ready for committing and stuff but ideally I can get this still done today (CET)