search

solokeys / solo1

Solo 1 firmware in C
https://solokeys.com/
Other
2.31k stars 273 forks source link

Papercuts #158

Open nickray opened 5 years ago

nickray commented 5 years ago

This is the list of currently known issues that are

The plan is to fix these if either

  1. ~U2F counter starts at 2130706432 instead of zero (FIDO2 counter not affected): https://github.com/solokeys/solo/blob/4e21c0bd8ff18c9066b88b549a54289901ae482f/fido2/u2f.c#L250~ (fixed in firmware v2.1)
  2. Resident Key display name limited to 32 instead of 64 characters: https://github.com/solokeys/solo/blob/4e21c0bd8ff18c9066b88b549a54289901ae482f/fido2/ctap.h#L104
mutantmonkey commented 5 years ago

U2F counter starts at 2130706432 instead of zero (FIDO2 counter not affected):

This seems like it's more than a minor problem. If I register in a browser that only uses U2F/CTAP1 and then try to authenticate in a browser using CTAP2, won't that cause authentication to fail? It seems like at the very least this same treatment would need to be applied to the CTAP2 counter.

conorpp commented 5 years ago

Great point! Will just rip the band aid off now and update U2F counter for good.

onlykey commented 5 years ago

@conorpp @nickray I am working on porting Solo firmware over to OnlyKey. Its different hardware so unfortunately there are lots of changes that were required (i.e. We use hardware wear leveled EEPROM). A couple of question related to 2. above:

aseigler commented 5 years ago

With regard to RKs and https://fido2.azurewebsites.net, best I recall is that it does work, but possibly only with certain browsers.

0x0ece commented 5 years ago

demo.yubico.com also has a demo for RK