search

solokeys / solo1

Solo 1 firmware in C
https://solokeys.com/
Other
2.3k stars 273 forks source link

Non compliance with spec in ctap_parse_client_pin ? #612

Open tgagneret-embedded opened 2 years ago

tgagneret-embedded commented 2 years ago

Hi,

I was wondering where the spec specify these values: https://github.com/solokeys/solo1/blob/2884f95ff4d75d8934522ec49ea418a5457f8617/fido2/ctap.h#L66 https://github.com/solokeys/solo1/blob/2884f95ff4d75d8934522ec49ea418a5457f8617/fido2/ctap.h#L67

which are used in ctap_parse_client_pin: https://github.com/solokeys/solo1/blob/2884f95ff4d75d8934522ec49ea418a5457f8617/fido2/ctap_parse.c#L1520 https://github.com/solokeys/solo1/blob/2884f95ff4d75d8934522ec49ea418a5457f8617/fido2/ctap_parse.c#L1530

I checked on the following document: https://fidoalliance.org/specs/fido-v2.1-ps-20210615/fido-client-to-authenticator-protocol-v2.1-ps-20210615.html#authnrClientPin-cmd-dfn

Thanks